[webkit-reviews] review granted: [Bug 47597] Proposal: Require cross-organizational seconds for reviewer nominations : [Attachment 78863] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 11:00:19 PST 2011


Darin Adler <darin at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 47597: Proposal: Require cross-organizational seconds for reviewer
nominations
https://bugs.webkit.org/show_bug.cgi?id=47597

Attachment 78863: Patch
https://bugs.webkit.org/attachment.cgi?id=78863&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78863&action=review

OK. Lets do this. My grammatical tweak suggestions are not binding, of course.
For one thing they haven’t even been discussed with the rest of the reviewers.

> Websites/webkit.org/coding/commit-review-policy.html:102
> +community as a whole, and not just within their own place of employment or

This comma should be removed.

> Websites/webkit.org/coding/commit-review-policy.html:105
> +with the nominee (other than WebKit itself).</p>

This would be better with a comma rather than parentheses. I also think "the
WebKit project itself" would be clearer than "WebKit itself".


More information about the webkit-reviews mailing list