[webkit-reviews] review granted: [Bug 52890] IndexedDB corrupts data on disk : [Attachment 79751] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 52890: IndexedDB corrupts data on disk
https://bugs.webkit.org/show_bug.cgi?id=52890

Attachment 79751: Patch
https://bugs.webkit.org/attachment.cgi?id=79751&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79751&action=review

r=me

>> Source/WebCore/platform/sql/SQLiteStatement.cpp:388
>> +	if (size < 0 || size % sizeof(UChar) != 0)
> 
> Tests for true/false, null/non-null, and zero/non-zero should all be done
without equality comparisons.  [readability/comparison_to_zero] [5]

The latter seems more like a sanity check...should we assert it's not true? 
The following / is safe in that we won't read invalid memory.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:189
>  

get rid of second newline

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:198
> +	       "INSERT INTO ObjectStoreData2 SELECT * FROM ObjectStoreData",

I worry about this....and think we should probably just blow away the data.  No
one should have anything they really care about yet.