[webkit-reviews] review requested: [Bug 49791] [GTK] Implement SharedMemory for WebKit2 : [Attachment 79755] Reverted back to mmap implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 10:03:14 PST 2011


Amruth Raj <amruthraj at motorola.com> has asked  for review:
Bug 49791: [GTK] Implement SharedMemory for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=49791

Attachment 79755: Reverted back to mmap implementation
https://bugs.webkit.org/attachment.cgi?id=79755&action=review

------- Additional Comments from Amruth Raj <amruthraj at motorola.com>
As discussed on IRC, modifications done to the GMappedFile buffer are private
to the process which does the modifications. They can't be accessed by another
process. So, I reverted back to the mmap implementation. Additionally, usage of
g_get_tmp_dir() and closing the fd returned by g_mkstemp are addressed with
this patch.


More information about the webkit-reviews mailing list