[webkit-reviews] review granted: [Bug 52863] nrwt: suppress remaining integration tests for now : [Attachment 79687] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 21 02:40:43 PST 2011


Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 52863: nrwt: suppress remaining integration tests for now
https://bugs.webkit.org/show_bug.cgi?id=52863

Attachment 79687: Patch
https://bugs.webkit.org/attachment.cgi?id=79687&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79687&action=review

Maybe we should think about creating a new file suffix _integrationtest.py or
something and having test-webkitpy know how to run them with passed
--integration or some-such?

This looks good except for the None to [] change.

> Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:115
> +    def get_printer(self, args=[], single_threaded=False,

None is preferred for default arguments.  The default values are shared by all
instances, so if anything ever tried to mutate that args value, we'd have bad
news bears. :)


More information about the webkit-reviews mailing list