[webkit-reviews] review denied: [Bug 51809] [Chromium] Autofill should work with HTML5 form elements : [Attachment 79704] Added const version of toInputElement().

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 51809: [Chromium] Autofill should work with HTML5 form elements
https://bugs.webkit.org/show_bug.cgi?id=51809

Attachment 79704: Added const version of toInputElement().
https://bugs.webkit.org/attachment.cgi?id=79704&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79704&action=review

> Source/WebCore/dom/InputElement.cpp:292
> +    return const_cast<InputElement*>(toInputElement(static_cast<const
Element*>(element)));

Why all the const casting?

> Source/WebCore/dom/InputElement.cpp:295
> +const InputElement* toInputElement(const Element* element)

We don't ever have const pointers for Elements.  They don't make sense.  The
dom is always mutable (from refcounting if nothing else.  Why is this needed?

> Source/WebKit/chromium/src/WebInputElement.cpp:163
> +const WebInputElement* WebInputElement::toWebInputElement(const WebElement*
webElement)

Again, const makes no sense here.  At least for WebCore classes.