[webkit-reviews] review denied: [Bug 51587] [GTK] Remove mandatory Enchant dependency : [Attachment 79706] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 51587: [GTK] Remove mandatory Enchant dependency
https://bugs.webkit.org/show_bug.cgi?id=51587

Attachment 79706: Patch
https://bugs.webkit.org/attachment.cgi?id=79706&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79706&action=review

Looks good, but I have a few style nits.

> ChangeLog:9
> +	   Add enable-spell-checker option which decide whether to use spell
> +	   checker. If disabled, WebKit/GTK+ will not use enchant library.

Should be "which decides" and WebKitGTK+.

> Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp:32
> +#if ENABLE(SPELL_CHECKER)
>  #include <enchant.h>
> +#endif

Please split this out of the main block of includes now that it has an #ifdef
around it.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:39
> +#if ENABLE(SPELL_CHECKER)
>  #include <enchant.h>
> +#endif

Ditto.

> Source/WebKit/gtk/webkit/webkitwebsettings.cpp:1267
> +	   g_value_set_boolean(value, false);

You should use FALSE here explicitly.