[webkit-reviews] review denied: [Bug 52869] Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation : [Attachment 79701] [patch] second iteration

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 52869: Web Inspector: switch page/Console implementation from
InspectorController to InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=52869

Attachment 79701: [patch] second iteration
https://bugs.webkit.org/attachment.cgi?id=79701&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79701&action=review

> Source/WebCore/inspector/InspectorInstrumentation.cpp:571
> +    return
inspectorController->profilerAgent()->getCurrentUserInitiatedProfileName(increm
entProfileNumber);

ProfilerAgent may be 0 here, r- for this.

> Source/WebCore/inspector/InspectorInstrumentation.h:142
> +    static void addProfile(Page*, RefPtr<ScriptProfile>, ScriptCallStack*);

ScriptCallStack should be passed as PassOwnPtr since the profiler agent may
want to store the callstack in a console message.

> Source/WebCore/inspector/InspectorInstrumentation.h:902
> +    if (InspectorController* inspectorController =
inspectorControllerForPage(page))

There was no check for InspectorController, I don't think it can be 0 here.