[webkit-reviews] review granted: [Bug 52756] nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff : [Attachment 79502] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 52756: nrwt: remove fs refs from printing, test_failures,
test_expectations, text_diff
https://bugs.webkit.org/show_bug.cgi?id=52756

Attachment 79502: Patch
https://bugs.webkit.org/attachment.cgi?id=79502&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
> -	   return os.path.splitext(filename)[0] + modifier
> +	   # FIXME: technically this breaks if files don't use ".ext" to
indicate
> +	   # the extension, but passing in a Filesystem object here is a huge
> +	   # hassle.
> +	   return filename[filename.rfind('.')] + modifier

I might have just left this using os.path.splitext with a FIXME about using
filesystem instead.

> Tools/Scripts/webkitpy/layout_tests/test_types/text_diff.py:-36
> -from __future__ import with_statement

We're sure this isn't needed?