[webkit-reviews] review granted: [Bug 52771] nrwt: clean up almost all remaining port references : [Attachment 79527] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 52771: nrwt: clean up almost all remaining port references
https://bugs.webkit.org/show_bug.cgi?id=52771

Attachment 79527: Patch
https://bugs.webkit.org/attachment.cgi?id=79527&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79527&action=review

Looks sane.  Are you sure all the import with_statement removals are safe?

> Tools/ChangeLog:8
> +	   Need a short description and bug URL (OOPS!)

Missing bug url/title.

> Tools/Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:48
> +	   self._port = None

Shouldn't be needed.

> Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py:67
>	   if not port.check_image_diff():
> +	       # The port hasn't been built - don't run the tests.
>	       return

I'm confused why the tests depend on having a build here.

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:399
> +	   environment['DUMPRENDERTREE_TEMP'] = str(self._driver_tempdir)

Curious why this is needed?