[webkit-reviews] review granted: [Bug 52645] REGRESSION: Multi-second hangs in ImageQualityController::objectDestroyed() : [Attachment 79451] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 52645: REGRESSION: Multi-second hangs in
ImageQualityController::objectDestroyed()
https://bugs.webkit.org/show_bug.cgi?id=52645

Attachment 79451: Patch
https://bugs.webkit.org/attachment.cgi?id=79451&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79451&action=review

How can we measure the performance impact of deleting and recreating the
controller?

I’ll say review+ even though I have some uncertainties.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:147
> +    IntSize oldSize = innerMap ? innerMap->get(layer) : IntSize();

How about using a separate bool haveOldSize or isFirstResize instead of
treating 0, 0 as a magic value?

> Source/WebCore/rendering/RenderBoxModelObject.cpp:170
> -    // If this is the first time resizing this image, or its size is the
> +    // If this is the first time resizing  this image, or its size is the

Why the change?