[webkit-reviews] review granted: [Bug 52739] Make it possible for a WebKit2 client to print headers and footers : [Attachment 79476] proposed patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 52739: Make it possible for a WebKit2 client to print headers and footers
https://bugs.webkit.org/show_bug.cgi?id=52739

Attachment 79476: proposed patch
https://bugs.webkit.org/attachment.cgi?id=79476&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=79476&action=review

Note that this broke the Qt build. Please land a version that does not break
it.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1480
> +    NSRect footerRect = NSMakeRect(headerFooterLeft, [printInfo
bottomMargin] / scale - _data->_page->footerHeight(frame),
> +				      headerFooterWidth,
_data->_page->footerHeight(frame));
> +    NSRect headerRect = NSMakeRect(headerFooterLeft, (paperSize.height -
[printInfo topMargin]) / scale,
> +				      headerFooterWidth,
_data->_page->headerHeight(frame));

We normally don’t line things up like this, and just indent one tab stop. It’s
better for later renaming, for one thing.