[webkit-reviews] review granted: [Bug 52717] Web Inspector: move methods from InjectedScript domain into DOM, Runtime and Debugger domains. Introduce InspectorRuntimeAgent. : [Attachment 79418] [PATCH] Proposed change with missing files added.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 19 07:03:00 PST 2011


Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 52717: Web Inspector: move methods from InjectedScript domain into DOM,
Runtime and Debugger domains. Introduce InspectorRuntimeAgent.
https://bugs.webkit.org/show_bug.cgi?id=52717

Attachment 79418: [PATCH] Proposed change with missing files added.
https://bugs.webkit.org/attachment.cgi?id=79418&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79418&action=review

> Source/WebCore/inspector/InjectedScriptHost.cpp:152
> + 

Remove this space.

> Source/WebCore/inspector/InjectedScriptHost.cpp:158
> +InjectedScript InjectedScriptHost::injectedScriptForMainWorld()

injectedScriptForMainWorld -> injectedScriptForMainFrame

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:83
> +InjectedScript
InspectorRuntimeAgent::injectedScriptForObjectId(InspectorObject* objectId)

Let's move this method into InjectedScriptHost and move pushNodeToFrontend into
DOM agent.


More information about the webkit-reviews mailing list