[webkit-reviews] review denied: [Bug 52718] Send origin/url as part of speech input requests to the embedder. : [Attachment 79415] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Satish Sampath
<satish at chromium.org>'s request for review:
Bug 52718: Send origin/url as part of speech input requests to the embedder.
https://bugs.webkit.org/show_bug.cgi?id=52718

Attachment 79415: Patch
https://bugs.webkit.org/attachment.cgi?id=79415&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79415&action=review

> Source/WebCore/page/SpeechInput.cpp:96
> +bool SpeechInput::startRecognition(int listenerId, const IntRect&
elementRect, const AtomicString& language, const String& grammar,
PassRefPtr<SecurityOrigin> origin)

Just pass a pointer.

> Source/WebCore/page/SpeechInput.h:65
> +    bool startRecognition(int listenerId, const IntRect& elementRect, const
AtomicString& language, const String& grammar, PassRefPtr<SecurityOrigin>);

ditto

> Source/WebCore/page/SpeechInputClient.h:54
> +    virtual bool startRecognition(int requestId, const IntRect& elementRect,
const AtomicString& language, const String& grammar,
PassRefPtr<SecurityOrigin>) = 0;

ditto

> Source/WebCore/platform/mock/SpeechInputClientMock.cpp:54
> +bool SpeechInputClientMock::startRecognition(int requestId, const IntRect&
elementRect, const AtomicString& language, const String& grammar,
PassRefPtr<SecurityOrigin> origin)

ditto

> Source/WebCore/platform/mock/SpeechInputClientMock.h:57
> +    bool startRecognition(int requestId, const IntRect& elementRect, const
AtomicString& language, const String& grammar, PassRefPtr<SecurityOrigin>);

ditto

> Source/WebCore/rendering/TextControlInnerElements.cpp:440
> +		 RefPtr<SecurityOrigin>
origin(SecurityOrigin::create(document()->url()));

You should be able to get this some other way.

> Source/WebCore/rendering/TextControlInnerElements.cpp:441
> +		 if (speechInput()->startRecognition(m_listenerId, rect,
language, grammar, origin))

origin.get()

> Source/WebKit/chromium/src/SpeechInputClientImpl.cpp:67
> +bool SpeechInputClientImpl::startRecognition(int requestId, const
WebCore::IntRect& elementRect, const AtomicString& language, const String&
grammar, PassRefPtr<WebCore::SecurityOrigin> origin)

*

> Source/WebKit/chromium/src/SpeechInputClientImpl.h:61
> +    bool startRecognition(int requestId, const WebCore::IntRect&
elementRect, const AtomicString& language, const String& grammar,
PassRefPtr<WebCore::SecurityOrigin>);

*