[webkit-reviews] review denied: [Bug 50240] Unable to indirectly animate visibility of SVGUseElement : [Attachment 79120] Revised patch version 2

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 50240: Unable to indirectly animate visibility of SVGUseElement
https://bugs.webkit.org/show_bug.cgi?id=50240

Attachment 79120: Revised patch version 2
https://bugs.webkit.org/attachment.cgi?id=79120&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79120&action=review

Excellent, almost r+. Our common style is to indidicate a "green rect" as
success in the expected.png/txt files. Yours is red, please change the
transition from black -> red, to red -> green, then I'll r+/cq+ it. Thanks for
your patience :-)

> LayoutTests/svg/custom/use-inherit-style.svg:8
> +    <rect id="rect" x="0" y="0" width="100" height="60" />

Here you should use fill="red" as initial value...

> LayoutTests/svg/custom/use-inherit-style.svg:17
> +	   document.getElementById("g").setAttribute("fill", "red");

... and change it to fill="green" here.