[webkit-reviews] review denied: [Bug 51312] Make ContextShadow code cross-platform : [Attachment 79112] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 51312: Make ContextShadow code cross-platform
https://bugs.webkit.org/show_bug.cgi?id=51312

Attachment 79112: Patch
https://bugs.webkit.org/attachment.cgi?id=79112&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79112&action=review

I'm tempted to r+ this, though the public variables in ContextShadow lead to a
r-. Who allowed this to be landed? :-)

> Source/WebCore/platform/graphics/ContextShadow.h:82
> +    ContextShadowType m_type;
>  
>      Color m_color;
> -    int m_blurDistance;
> +    IntSize m_blurDistance;
>      FloatSize m_offset;

public variables?
This needs to be hidden....