[webkit-reviews] review denied: [Bug 51382] [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. : [Attachment 79135] Change names and indentation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 17 02:30:23 PST 2011


Kent Tamura <tkent at chromium.org> has denied  review:
Bug 51382: [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382

Attachment 79135: Change names and indentation.
https://bugs.webkit.org/attachment.cgi?id=79135&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79135&action=review

> Source/WebCore/ChangeLog:3
> +2011-01-13  Naoki Takano  <takano.naoki at gmail.com>
> +
> +	   [Chromium] Fix popup menu re-positioning when the menu is opened

The ChangeLog format is wrong.	Please insert " Reviewed by NOBODY (OOPS!)."
and 1 blank line between date&name and the summary line like the following.

2011-01-13  Naoki Takano  <takano.naoki at gmail.com>
 
	 Reviewed by NOBODY (OOPS!).
 
	 [Chromium] Fix popup menu ...

> WebKit/chromium/ChangeLog:3
> +2011-01-10  Naoki Takano  <takano.naoki at gmail.com>
> +
> +	   [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.

ditto.


More information about the webkit-reviews mailing list