[webkit-reviews] review denied: [Bug 52532] Web Inspector: make WebCore use InspectorInstrumentation for instrumentation calls. : [Attachment 79109] [PATCH] Proposed change

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 52532: Web Inspector: make WebCore use InspectorInstrumentation for
instrumentation calls.
https://bugs.webkit.org/show_bug.cgi?id=52532

Attachment 79109: [PATCH] Proposed change
https://bugs.webkit.org/attachment.cgi?id=79109&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=79109&action=review

> Source/WebCore/inspector/InspectorController.cpp:151
> +    InspectorInstrumentation::inspectorControllerCreated(page, this);

I'd rather declare a friend function that would get InspectorAgent from Page.

> Source/WebCore/inspector/InspectorInstrumentation.h:893
> +	   return
inspectorControllerWithFrontendForPage(static_cast<Document*>(context)->page())
;

Should return IC even if there is no FE

> Source/WebCore/inspector/InspectorInstrumentation.h:915
> +	   return inspectorControllerForContext(context);

Please check that the IC has FE