[webkit-reviews] review requested: [Bug 51382] [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. : [Attachment 79057] Restore layout() call

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 23:59:08 PST 2011


Naoki Takano <takano.naoki at gmail.com> has asked  for review:
Bug 51382: [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382

Attachment 79057: Restore layout() call
https://bugs.webkit.org/attachment.cgi?id=79057&action=review

------- Additional Comments from Naoki Takano <takano.naoki at gmail.com>
Sorry for bothering you again.

But I restore layout() call to layoutAndCalculateWidgetRect().
Because my previous patch does not work well about layout() and setMaxHeight()
call.
I tried to rewrite it as the same call without layout() call, but it became
confusing.

Please review it.

Thanks,


More information about the webkit-reviews mailing list