[webkit-reviews] review canceled: [Bug 51382] [Chromium] Fix popup menu re-positioning when the menu is opened upward, above the corresponding form field. : [Attachment 78899] Fix comments and pull out setMaxHeight() call.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 14 23:59:08 PST 2011
Naoki Takano <takano.naoki at gmail.com> has canceled Naoki Takano
<takano.naoki at gmail.com>'s request for review:
Bug 51382: [Chromium] Fix popup menu re-positioning when the menu is opened
upward, above the corresponding form field.
https://bugs.webkit.org/show_bug.cgi?id=51382
Attachment 78899: Fix comments and pull out setMaxHeight() call.
https://bugs.webkit.org/attachment.cgi?id=78899&action=review
------- Additional Comments from Naoki Takano <takano.naoki at gmail.com>
Sorry for bothering you again.
But I restore layout() call to layoutAndCalculateWidgetRect().
Because my previous patch does not work well about layout() and setMaxHeight()
call.
I tried to rewrite it as the same call without layout() call, but it became
confusing.
Please review it.
Thanks,
More information about the webkit-reviews
mailing list