[webkit-reviews] review denied: [Bug 48509] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy, WebView classes for WebKit2 and add WKAPI : [Attachment 78234] Changes to WKAPI interfaces for GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 10:06:10 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 48509: [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy, WebView
classes for WebKit2 and add WKAPI
https://bugs.webkit.org/show_bug.cgi?id=48509

Attachment 78234: Changes to WKAPI interfaces for GTK port
https://bugs.webkit.org/attachment.cgi?id=78234&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78234&action=review

> WebKit2/UIProcess/API/C/gtk/WKView.h:37
> +WK_EXPORT WKViewRef WKViewCreate(GdkRectangle rect, WKContextRef context,
WKPageGroupRef pageGroup, GtkWidget * hostWindow);

Since the GdkRectangle parameter is currently unused, I'd say just leave it out
for now. You have an extra space after GtkWidget.


More information about the webkit-reviews mailing list