[webkit-reviews] review denied: [Bug 48509] [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy, WebView classes for WebKit2 and add WKAPI : [Attachment 78232] UpdateChunk, ChunkedUpdateDrawingArea implementation for GTK port

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 10:04:53 PST 2011


Martin Robinson <mrobinson at webkit.org> has denied Ravi Phaneendra Kasibhatla
<ravi.kasibhatla at motorola.com>'s request for review:
Bug 48509: [GTK] Implement UpdateChunk, ChunkedUpdateDrawingArea/Proxy, WebView
classes for WebKit2 and add WKAPI
https://bugs.webkit.org/show_bug.cgi?id=48509

Attachment 78232: UpdateChunk, ChunkedUpdateDrawingArea implementation for GTK
port
https://bugs.webkit.org/attachment.cgi?id=78232&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78232&action=review

r- because this should almost certainly use cairo surfaces instead of
GdkPixmaps.

> WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:28
> -#ifndef DrawingAreaProxyUpdateChunk_h
> -#define DrawingAreaProxyUpdateChunk_h
> +#ifndef ChunkedUpdateDrawingAreaProxy_h
> +#define ChunkedUpdateDrawingAreaProxy_h

This is a good change, but I think it can go in a separate cleanup patch.


More information about the webkit-reviews mailing list