[webkit-reviews] review granted: [Bug 52216] GeolocationController should call stopUpdating on destruction : [Attachment 78936] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 14 06:19:23 PST 2011


Jeremy Orlow <jorlow at chromium.org> has granted John Knottenbelt
<jknotten at chromium.org>'s request for review:
Bug 52216: GeolocationController should call stopUpdating on destruction
https://bugs.webkit.org/show_bug.cgi?id=52216

Attachment 78936: Patch
https://bugs.webkit.org/attachment.cgi?id=78936&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78936&action=review

r=me

> LayoutTests/platform/gtk/Skipped:4919
> +fast/dom/Geolocation/window-close-crash.html

Just skip the whole directory

> LayoutTests/platform/mac-wk2/Skipped:1578
> +fast/dom/Geolocation/window-close-crash.html

Just skip the whole directory

> LayoutTests/platform/qt-wk2/Skipped:1740
> +fast/dom/Geolocation/window-close-crash.html

Just skip the whole directory


More information about the webkit-reviews mailing list