[webkit-reviews] review granted: [Bug 52377] Web Inspector: provide script column offset to frontend : [Attachment 78928] Comments addressed.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 52377: Web Inspector: provide script column offset to frontend
https://bugs.webkit.org/show_bug.cgi?id=52377

Attachment 78928: Comments addressed.
https://bugs.webkit.org/attachment.cgi?id=78928&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78928&action=review

> Source/WebCore/inspector/front-end/Script.js:31
> +    this.lineOffset = lineOffset;

Consider using the same names as in SourceCode.h for consistency.

> Source/WebCore/inspector/front-end/Script.js:36
> +    this.startingLine = lineOffset + 1;

Please remove this field and use only lineOffset, clients should add 1 when
needed.