[webkit-reviews] review granted: [Bug 52282] Web Inspector: extract console related functionality into InspectorConsoleAgent : [Attachment 78813] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 13 08:34:51 PST 2011


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 52282: Web Inspector: extract console related functionality into
InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282

Attachment 78813: Patch
https://bugs.webkit.org/attachment.cgi?id=78813&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78813&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:252
> +    addConsoleMessage: function(payload)

I know Ilya has been doing it earlier, but I think it is wrong. We should
dispatch against private closure.


More information about the webkit-reviews mailing list