[webkit-reviews] review denied: [Bug 48812] FrameLoader::checkLoadCompleteForThisFrame uses wrong history item : [Attachment 75044] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied  review:
Bug 48812: FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
https://bugs.webkit.org/show_bug.cgi?id=48812

Attachment 75044: Patch
https://bugs.webkit.org/attachment.cgi?id=75044&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Sorry this patch has been sitting here with an r+ for awhile and that I'm just
doing this, but reading my bugzilla CC email I noticed something I really
dislike here.

I understand the motivation for reordering the arguments was the "null vs bool"
ambiguity.  A much better way to fix that besides reordering the arguments
would be to take this opportunity to replace the bool with an enum.  

Since it's been so long I'm going to change to r- in hopes this can be done
before landing.