[webkit-reviews] review denied: [Bug 52292] Web Inspector: redirected resources not handled properly in Network panel : [Attachment 78803] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 52292: Web Inspector: redirected resources not handled properly in Network
panel
https://bugs.webkit.org/show_bug.cgi?id=52292

Attachment 78803: patch
https://bugs.webkit.org/attachment.cgi?id=78803&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78803&action=review

> Source/WebCore/inspector/front-end/ConsoleView.js:671
> +		   var resource = this._requestId &&
WebInspector.panels.network.resourceById(this._requestId);

WebInspector.networkResourcesById()

> Source/WebCore/inspector/front-end/ExtensionServer.js:291
> +	   resource = WebInspector.panels.network.resourceById(id) ||
WebInspector.resourceForURL(id);

I like the way it was more.

> Source/WebCore/inspector/front-end/ExtensionServer.js:321
> +	   var resource = WebInspector.panels.network.resourceById(message.id);


ditto.

> Source/WebCore/inspector/front-end/NetworkManager.js:100
> +	       WebInspector.panels.network.mainResourceChanged();

Updating main resource here and resetting network panel can't be done here.

> Source/WebCore/inspector/front-end/NetworkManager.js:220
> +	   var resource = WebInspector.panels.network.resourceById(identifier);


ditto

> Source/WebCore/inspector/front-end/NetworkManager.js:305
> +	   this._resourceTreeModel.bindResourceURL(resource);

You should be careful with bindResourceURL since unbind is automated and is
only called for frame's resources.