[webkit-reviews] review granted: [Bug 52294] Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent. : [Attachment 78800] [patch] another version

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 52294: Web Inspector: Extract BrowserDebuggerAgent from
InspectorController, InspectorDOMAgent and InspectorDebugger agent.
https://bugs.webkit.org/show_bug.cgi?id=52294

Attachment 78800: [patch] another version
https://bugs.webkit.org/attachment.cgi?id=78800&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78800&action=review

I still don't like InspectorBrowserDebuggerAgent name because there is no such
thing as browser in terms of WebCore, otherwise the change looks good to me.

> Source/WebCore/inspector/InspectorDOMAgent.h:147
> +	   // We represent embedded doms as a part of the same hierarchy. Hence
we treat children of frame owners differently.

Consider moving these methods into a separate utility class.

> Tools/ChangeLog:5
> +	   clean

Please provide a meaningful description.