[webkit-reviews] review granted: [Bug 20677] WebKit wraps between hyphen-minus and numeric characters : [Attachment 66008] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 14:44:11 PST 2011


Adam Barth <abarth at webkit.org> has granted Xianzhu Wang <phnixwxz at gmail.com>'s
request for review:
Bug 20677: WebKit wraps between hyphen-minus and numeric characters
https://bugs.webkit.org/show_bug.cgi?id=20677

Attachment 66008: Updated patch
https://bugs.webkit.org/attachment.cgi?id=66008&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is a tough call.  Mitz and Darin agree that this is the right
approach for implementing this behavior if this is the behavior we want. 
Several folks have differed to Hyatt w.r.t. whether this is the behavior we
want, especially in connection with URLs.  The new behavior moves us to be more
Firefox-like than IE-like and moves us closer to the spec.  In the common case,
it seems like the new behavior will be ok for URLs.  The bad case is probably
something like the old Amazon URLs with long strings of hyphenated numbers... 
I'm marking this R+, but it would be nice to hear from Hyatt before landing.


More information about the webkit-reviews mailing list