[webkit-reviews] review denied: [Bug 42756] JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap? : [Attachment 78732] overcommit.diff

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 12 14:52:26 PST 2011


Oliver Hunt <oliver at apple.com> has denied Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 42756: JIT requires VM overcommit (particularly on x86-64), Linux does not
by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756

Attachment 78732: overcommit.diff
https://bugs.webkit.org/attachment.cgi?id=78732&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
i think 32mb will be far too little to be useful -- a simple test would be for
you to just try using midori with a jsc build with vmPoolSizeGeneric == 32mb

Also i think the logic to determine what size the allocation should be would be
better in a separate function.


More information about the webkit-reviews mailing list