[webkit-reviews] review granted: [Bug 52173] [GTK] Remove use of deprecated GTK+ methods before the 1.3.10 release : [Attachment 78462] Patch

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 52173: [GTK] Remove use of deprecated GTK+ methods before the 1.3.10
release
https://bugs.webkit.org/show_bug.cgi?id=52173

Attachment 78462: Patch
https://bugs.webkit.org/attachment.cgi?id=78462&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78462&action=review

> WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp:275
> +    GdkColor color = { 1, 0, 0, 0 };

Changing this seems a bit pointless? I hope it's right ;) /me too lazy to check


> WebKit/gtk/webkit/webkitwebview.cpp:1553
> +    GdkModifierType modifier = static_cast<GdkModifierType>(0);

This made more sense in plural.