[webkit-reviews] review granted: [Bug 51866] Use __builtin_expect when compiling using RVCT in GNU mode : [Attachment 78461] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 51866: Use __builtin_expect when compiling using RVCT in GNU mode
https://bugs.webkit.org/show_bug.cgi?id=51866

Attachment 78461: Patch
https://bugs.webkit.org/attachment.cgi?id=78461&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78461&action=review

> Source/JavaScriptCore/wtf/Platform.h:79
> +/* Define this for !RVCT compilers, just so we can write things like
COMPILER(RVCT) && RVCT_VERSION_AT_LEAST(3,0,0,0). */

It occurs to me that this means that you could always just use
RVCT_VERSION_AT_LEAST(3,0,0,0) without COMPILER(RVCT); maybe we should.

> Source/JavaScriptCore/wtf/Platform.h:91
> -/* define this for !GCC compilers, just so we can write things like
COMPILER(GCC) && GCC_VERSION_AT_LEAST(4,1,0) */
> +/* Define this for !GCC compilers, just so we can write things like
COMPILER(GCC) && GCC_VERSION_AT_LEAST(4,1,0). */
>  #define GCC_VERSION_AT_LEAST(major, minor, patch) 0

It occurs to me that this means that you could always just use
GCC_VERSION_AT_LEAST(3,0,0,0) without COMPILER(GCC); maybe we should.