[webkit-reviews] review denied: [Bug 52080] Add background-clip to background shorthand : [Attachment 78270] Patch to add background-clip to background shorthand
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 10 13:44:02 PST 2011
Eric Seidel <eric at webkit.org> has denied krithigassree.sambamurthy at nokia.com's
request for review:
Bug 52080: Add background-clip to background shorthand
https://bugs.webkit.org/show_bug.cgi?id=52080
Attachment 78270: Patch to add background-clip to background shorthand
https://bugs.webkit.org/attachment.cgi?id=78270&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78270&action=review
It seems we need more testing than this, no? Don't we need examples of it
being parsed as part of the shorthand? Or am I misunderstanding?
> WebCore/css/CSSParser.cpp:1966
> + if (!parsedProperty[i]) {
whitespace.
More information about the webkit-reviews
mailing list