[webkit-reviews] review denied: [Bug 52169] [chromium] Call WebAutoFillClient instead of WebViewClient for autofill related callbacks : [Attachment 78442] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 10 13:42:38 PST 2011
James Robinson <jamesr at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 52169: [chromium] Call WebAutoFillClient instead of WebViewClient for
autofill related callbacks
https://bugs.webkit.org/show_bug.cgi?id=52169
Attachment 78442: Patch
https://bugs.webkit.org/attachment.cgi?id=78442&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78442&action=review
Please update the chromium_rev line in WebKit/chromium/DEPS so the builds don't
break.
> WebKit/chromium/src/WebViewImpl.h:372
> + WebViewImpl(WebViewClient* client,
> + WebDevToolsAgentClient* devToolsClient,
> + WebAutoFillClient* autoFillClient);
WebKit style is to leave out the parameter names for params like this.
More information about the webkit-reviews
mailing list