[webkit-reviews] review granted: [Bug 52044] REGRESSION(r74807): No-store is ignored within a document : [Attachment 78393] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 52044: REGRESSION(r74807): No-store is ignored within a document
https://bugs.webkit.org/show_bug.cgi?id=52044

Attachment 78393: patch
https://bugs.webkit.org/attachment.cgi?id=78393&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78393&action=review

> However  we should never load a resource more than once during page loading

Definitely agreed.

Would you be willing to file a bug about no-cache?

> Source/WebCore/ChangeLog:6
> +	   REGRESSION(r74807): No-cache is ignored within a document

No-cache?

> LayoutTests/ChangeLog:10
> +	   * http/tests/misc/resources/random.php: Added.

I'd have renamed this random-no-store.php. Maybe the .html file, too.