[webkit-reviews] review granted: [Bug 52031] [WIN] Add ProxyServerWin.cpp : [Attachment 78177] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 10 08:45:25 PST 2011


Laszlo Gombos <laszlo.1.gombos at nokia.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 52031: [WIN] Add ProxyServerWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=52031

Attachment 78177: Patch
https://bugs.webkit.org/attachment.cgi?id=78177&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
LGTM, r+. ResourceHandleWin.cpp seems to be a similar case; no guard as it is
only picked up by WinCE build system.

I would still prefer to have some indication in the cpp files that these are at
the moment only for WinCE (e.g. OS(x) guard), but it seems that this should be
done for some other files as well, so perhaps it should be a separate patch.


More information about the webkit-reviews mailing list