[webkit-reviews] review denied: [Bug 51559] copyTexSubImage2D shouldn't have undefined pixels : [Attachment 78166] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 51559: copyTexSubImage2D shouldn't have undefined pixels
https://bugs.webkit.org/show_bug.cgi?id=51559

Attachment 78166: Patch
https://bugs.webkit.org/attachment.cgi?id=78166&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=78166&action=review

This basically looks good. One issue needing a revision.

> WebCore/html/canvas/WebGLRenderingContext.cpp:752
> +	       m_context->texSubImage2D(target, level, xoffset, yoffset, width,
height, format, type, zero.get());

The unpack alignment needs to be set to 1 before this call and restored
afterward. See the various WebGLRenderingContext::texSubImage2D variants in
this file.