[webkit-reviews] review denied: [Bug 51957] Provide test cases for testing contentEditable DOM attribute : [Attachment 78158] fix patch 2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 51957: Provide test cases for testing contentEditable DOM attribute
https://bugs.webkit.org/show_bug.cgi?id=51957

Attachment 78158: fix patch 2
https://bugs.webkit.org/attachment.cgi?id=78158&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78158&action=review

r- because I want you to file bugs and refer to those bug numbers in the test. 
It'll be also nice if you could get rid of blanks lines at the end of each test
result.

> LayoutTests/editing/editability/attr-empty-string-expected.txt:12
> +PASS document.defaultView.getComputedStyle(div,
"").getPropertyValue("-webkit-user-modify") is "read-write"

You should probably call window.getComputedStyle but if I'm fine with it if
you're doing this to be compatible with IE.

> LayoutTests/editing/editability/attr-invalid-string-expected.txt:10
> +FAIL document.getElementById("div").contentEditable should be inherit. Was
false.

Need to file a bug and refer to that bug (talked on IRC).

> LayoutTests/editing/editability/attr-invalid-string-expected.txt:20
> +
> +
> +
> +

I think you can get rid of these blank lines if you hid div.  The same goes for
other tests.