[webkit-reviews] review denied: [Bug 51811] Merge m_height and m_width members of ImageData into a common m_size member : [Attachment 78113] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Renata Hodovan <reni at webkit.org>'s
request for review:
Bug 51811: Merge m_height and m_width members of ImageData into a common m_size
member
https://bugs.webkit.org/show_bug.cgi?id=51811

Attachment 78113: Patch
https://bugs.webkit.org/attachment.cgi?id=78113&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78113&action=review

Nearly done, just some snippets.

> WebCore/bindings/js/SerializedScriptValue.cpp:503
> +    void write(int32_t i)
> +    {
> +	   writeLittleEndian(m_buffer, i);
> +    }
> +

Do we still need void write(uint32_t i)? I guess it is still useful :-/

> WebCore/html/ImageData.h:47
> +    int width() const { return m_size.width(); }
> +    int height() const { return m_size.height(); }

I read the comment of Andreas
(https://bugs.webkit.org/show_bug.cgi?id=51811#c9), but I don't think that
these lines should still be included. Are we doing something similar somewhere
else? I don't think so. This should be removed, and all callers replaced by
size().width()/height().

> WebCore/platform/graphics/haiku/ImageBufferHaiku.cpp:249
> +    return result.release();

Looks like you forgot one early return above this line:

if (rect.x() > size.width() || rect.y() > size.height() || rect.right() < 0 ||
rect.bottom() < 0)
		return result;

should be return result.release(); as well.

> WebCore/platform/graphics/haiku/ImageBufferHaiku.cpp:257
> +    return getImageData(rect, m_data, m_size, false).release();

The release is wrong here.

> WebCore/platform/graphics/haiku/ImageBufferHaiku.cpp:264
> +    return getImageData(rect, m_data, m_size, true).release();

The release is wrong here.