[webkit-reviews] review requested: [Bug 51453] [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded() : [Attachment 78114] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 6 06:52:59 PST 2011


Jan Erik Hanssen <jhanssen at gmail.com> has asked  for review:
Bug 51453: [Qt] crash in QNetworkReplyHandler::sendResponseIfNeeded()
https://bugs.webkit.org/show_bug.cgi?id=51453

Attachment 78114: Patch
https://bugs.webkit.org/attachment.cgi?id=78114&action=review

------- Additional Comments from Jan Erik Hanssen <jhanssen at gmail.com>
The problem encountered with the manual test in this case is that emitting
processQueuedItems() may cause the ResourceHandle that owns the current
QNetworkReplyHandler to be destroyed, setting m_reply to 0. This patch checks
if m_reply is 0 before using. This may be related to bug 51641


More information about the webkit-reviews mailing list