[webkit-reviews] review granted: [Bug 51855] Extract ThreadFunctionInvocation into separate file and share between Apple Windows and Android : [Attachment 77900] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 51855: Extract ThreadFunctionInvocation into separate file and share
between Apple Windows and Android
https://bugs.webkit.org/show_bug.cgi?id=51855

Attachment 77900: Patch
https://bugs.webkit.org/attachment.cgi?id=77900&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77900&action=review

> Source/JavaScriptCore/wtf/ThreadingPthreads.cpp:161
> +    if (pthread_create(&threadHandle, 0, runThreadWithRegistration,
invocation)) {

This shouldn't compile. If it does, we should find out why. You should be
passing invocation.get().