[webkit-reviews] review denied: [Bug 51693] [chromium] editing/input/ime-composition-clearpreedit.html fails in chromium. : [Attachment 77822] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 4 10:41:53 PST 2011


Kenneth Russell <kbr at google.com> has denied James Su <suzhe at chromium.org>'s
request for review:
Bug 51693: [chromium] editing/input/ime-composition-clearpreedit.html fails in
chromium.
https://bugs.webkit.org/show_bug.cgi?id=51693

Attachment 77822: Patch
https://bugs.webkit.org/attachment.cgi?id=77822&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=77822&action=review

The code changes look okay to me (though I am not an expert on input methods)
-- but please document the Qt code changes in WebKit/qt/ChangeLog.

> WebKit/qt/ChangeLog:10
> +	   * Api/qwebpage.cpp:
> +	   (QWebPagePrivate::inputMethodEvent):

Please document these changes.


More information about the webkit-reviews mailing list