[webkit-reviews] review denied: [Bug 55237] Web Inspector: extract content loading logic from scripts panel : [Attachment 83843] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 08:54:09 PST 2011


Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 55237: Web Inspector: extract content loading logic from scripts panel
https://bugs.webkit.org/show_bug.cgi?id=55237

Attachment 83843: Patch.
https://bugs.webkit.org/attachment.cgi?id=83843&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83843&action=review

This change looks scary. Could you split it into number of changes?

> Source/WebCore/ChangeLog:950
> +	   to -1. Since WebKit2 doesn�t support non-activating clicks yet
(<http://webkit.org/b/55053>

Is this change intentional?

> Source/WebCore/inspector/front-end/DebuggerModel.js:47
>      BreakpointAdded: "breakpoint-added",

I thought you were going to get rid of this one?

> Source/WebCore/inspector/front-end/DebuggerModel.js:50
> +    InspectedURLChanged: "inspected-url-changed"

It is not clear why this event should be fired on debugger model.


More information about the webkit-reviews mailing list