[webkit-reviews] review granted: [Bug 55221] Build fix for Intel ICC Compiler : [Attachment 84041] New patch with Alexey's comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 28 08:53:00 PST 2011
Alexey Proskuryakov <ap at webkit.org> has granted Alexis Menard
<alexis.menard at openbossa.org>'s request for review:
Bug 55221: Build fix for Intel ICC Compiler
https://bugs.webkit.org/show_bug.cgi?id=55221
Attachment 84041: New patch with Alexey's comments
https://bugs.webkit.org/attachment.cgi?id=84041&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+{
+
+}
We don't put a blank line in empty function bodies.
+ // This destructor is needed in order to link correctly with Intel ICC.
The comment is only needed to prevent accidental removal of the destructor - it
would be sufficient (and better) to only have it in .cpp file. People looking
for something else in the header don't need to know about this.
More information about the webkit-reviews
mailing list