[webkit-reviews] review granted: [Bug 54292] remove the support of Frame::isContentEditable and its dependencies : [Attachment 83394] fix patch 6

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 54292: remove the support of Frame::isContentEditable and its dependencies
https://bugs.webkit.org/show_bug.cgi?id=54292

Attachment 83394: fix patch 6
https://bugs.webkit.org/attachment.cgi?id=83394&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
(In reply to comment #33)
> > > It seems to me the new behavior is the right one and we should update the
expected results. Agree? Disagree?
> > 
> > But why does updating layout causes new text nodes to appear?  These new
spaces do exist in the code but I'm not sure if we should be emitting them in
the render tree when they're at end of lines.  Could someone familiar with the
rendering engine comment on this point?
> 
> Function Editor::applyEditingStyleToElement sets some properties:
>     style->setProperty(CSSPropertyWordWrap, "break-word", false, ec);
>     style->setProperty(CSSPropertyWebkitNbspMode, "space", false, ec);
>     style->setProperty(CSSPropertyWebkitLineBreak, "after-white-space",
false, ec);

Ok.  The change looks same to me so let's hope that this won't cause any
regressions.  Thanks a lot for making this change!  I believe this and your
follow-up patch will greatly improve the performance.