[webkit-reviews] review granted: [Bug 55330] [Qt] [WK2] QGraphicsWKView::showContextMenu() should be public : [Attachment 83993] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Feb 27 15:03:49 PST 2011
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 55330: [Qt] [WK2] QGraphicsWKView::showContextMenu() should be public
https://bugs.webkit.org/show_bug.cgi?id=55330
Attachment 83993: Patch
https://bugs.webkit.org/attachment.cgi?id=83993&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83993&action=review
Very nice to see documentation for our WebKit2 classes!
> Source/WebKit2/UIProcess/API/qt/qgraphicswkview.cpp:335
> + actions possible for its current position, it is empty if there is no
action for the position.
I don't think it should be a comma here. Maybe ; would do, or you could add
another sentence instead.
More information about the webkit-reviews
mailing list