[webkit-reviews] review granted: [Bug 54374] Add method to make BuildBot return test outputs : [Attachment 83604] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 21:50:03 PST 2011


Ojan Vafai <ojan at chromium.org> has granted James Kozianski <koz at chromium.org>'s
request for review:
Bug 54374: Add method to make BuildBot return test outputs
https://bugs.webkit.org/show_bug.cgi?id=54374

Attachment 83604: Patch
https://bugs.webkit.org/attachment.cgi?id=83604&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=83604&action=review

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:237
> +    def results_zip_url(self):
> +	   return "%s.zip" % self.results_url()
> +
> +    def results(self):
> +	   return TestOutputSet(self._builder.name(), None,
ZipFileSet(self.results_zip_url()), include_expected=False)
> +

I know this is a bit inane, but can you write tests for these too. They don't
need to actually verify the output. It just ensures that they run without
errors.

results_zip_url can just verify that it gets the right string back and
TestOutputSet can just verify that it gets a non-None value back.


More information about the webkit-reviews mailing list