[webkit-reviews] review requested: [Bug 54926] All Console Messages should be passed to ChromeClients. : [Attachment 83605] [PATCH] Addressed Comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 21:49:08 PST 2011


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 54926: All Console Messages should be passed to ChromeClients.
https://bugs.webkit.org/show_bug.cgi?id=54926

Attachment 83605: [PATCH] Addressed Comments
https://bugs.webkit.org/attachment.cgi?id=83605&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Addressed Timothy Hatcher's comments. I added a new delegate, which doesn't
filter.
The old delegate, does filter to receive just JSMessageSource messages. The two

delegates are exclusive; so if the new delegate is implemented, than it will
get
called and the old delegate won't.


More information about the webkit-reviews mailing list