[webkit-reviews] review granted: [Bug 48781] Add a resourceload delegate method to query if WebCore should paint the default broken image for failed images. : [Attachment 78883] fix style violation.

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Yongjun Zhang
<yongjun_zhang at apple.com>'s request for review:
Bug 48781: Add a resourceload delegate method to query if WebCore should paint
the default broken image for failed images.
https://bugs.webkit.org/show_bug.cgi?id=48781

Attachment 78883: fix style violation.
https://bugs.webkit.org/attachment.cgi?id=78883&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=78883&action=review

r=me, but consider the comments.

> WebKit/mac/WebView/WebResourceLoadDelegatePrivate.h:59
> + @param imageURL The url of the offending image.

Maybe use "broken" instead of "offending" here.

> LayoutTests/fast/images/support-broken-image-delegate.html:26
> +<img id="broken" onError="loaded()" onLoad="loaded()"
src="resources/broken-image-with-invalid-format.png">

Instead of calling loaded() in the onload="" attribute, can you call a
different function that always sets result.innerHTML to "FAIL" since this code
path is unexpected?  (Or is there a reason for setting onload and onerror to
the same function?)

> LayoutTests/fast/images/resources/broken-image-with-invalid-format.png:1
> +fsadljf903q2asdfic-=29q24;lasdf

Is the MIME type for this file correct?  Strange that it shows up as text in
the diff.  May need to fix this up in svn after the commit.