[webkit-reviews] review requested: [Bug 54514] Need API to view origins which have items in the Application Cache and delete items for those origins : [Attachment 83346] Patch v2 (With critical ENABLE(OFFLINE_WEB_APPLICATIONS) protectors in places that might break the build for some platforms)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 22 11:13:01 PST 2011


Brady Eidson <beidson at apple.com> has asked  for review:
Bug 54514: Need API to view origins which have items in the Application Cache
and delete items for those origins
https://bugs.webkit.org/show_bug.cgi?id=54514

Attachment 83346: Patch v2 (With critical ENABLE(OFFLINE_WEB_APPLICATIONS)
protectors in places that might break the build for some platforms)
https://bugs.webkit.org/attachment.cgi?id=83346&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Brian reminded me we need #if ENABLE(OFFLINE_WEB_APPLICATIONS) flags here.

I don't know how feasible it is to properly #if
ENABLE(OFFLINE_WEB_APPLICATIONS) everything added here, especially with regards
to API and *messages.in files.

This patch adds critical #if ENABLE(OFFLINE_WEB_APPLICATIONS) guards to the
WebCore callsites that will at least keep everyone building, and will behave as
if the app cache is there, but is just always empty.


More information about the webkit-reviews mailing list