[webkit-reviews] review canceled: [Bug 32510] [GTK] provide an API to control the IconDatabase : [Attachment 83166] Implement WebKitIconDatabase API

[bugzilla-daemon at webkit.org]

Christian Dywan <christian at twotoasts.de> has canceled Christian Dywan
<christian at twotoasts.de>'s request for review:
Bug 32510: [GTK] provide an API to control the IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=32510

Attachment 83166: Implement WebKitIconDatabase API
https://bugs.webkit.org/attachment.cgi?id=83166&action=review

------- Additional Comments from Christian Dywan <christian at twotoasts.de>
So I implemented WebKitIconDatabase now. With methods

set_path() to set the folder on disk, or NULL to unset it.
get_icon_uri() to get the icon URI for a page URI
get_icon_pixbuf to get a GdkPixbuf for a page URI
clear() to clear all icons
"icon-loaded" signal with the page URI as the argument, similar to the same
signal on WebKitWebView but emitted for any icon including sub frames. This
makes it possible to handle icon updates isolated from a particular view (tab).


I also added get_icon_pixbuf() to WebKitWebView because I figure this is a very
common use case and I know that a lot of people ask for this in #webkit-gtk,
and it is so much easier and also more efficient than having to load the icon
with WebKitDownload.

No retaining API as of yet, I'm a bit unsure if/ how this should be exposed.